create_fresh_base_sysimage()
: Pass ""
as the BUILDROOT for Julia 1.12+
#996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989.
This fixes the immediate bug in #989, which is that Base.jl incorrectly assumes that our first positional argument is the value of the
BUILDROOT
. The fix is to pass a second positional argument""
, which is then taken by Base.jl to be theBUILDROOT
.This bugfix PR will eventually be followed up by #997, which is a larger PR that will actually take advantage of the new BuildSettings mechanism added to Julia 1.12 in JuliaLang/julia#54387